WIP: Email localization (fixes #500) #2053
Conversation
Nutomic
force-pushed
the
email-localization
branch
3 times, most recently
from
6be867c
to
e17cce7
Compare
|
Updated, basic implementation is now done. For now it uses separate translation files (which need to get moved into lemmy-translations repo). After upstream changes we should be able to merge it with existing translation files. I'm not really happy with the way the code is structured now, as email notification logic is split across crates |
Nutomic
force-pushed
the
email-localization
branch
from
e17cce7
to
82c3ca3
Compare
Nutomic
force-pushed
the
email-localization
branch
from
82c3ca3
to
61bd53d
Compare
|
@dessalines Could you have a look at this? |
| @@ -104,11 +105,16 @@ impl PerformCrud for CreatePrivateMessage { | |||
| LocalUserView::read_person(conn, recipient_id) | |||
| }) | |||
| .await??; | |||
| let lang = get_user_lang(&local_recipient); | |||
| let inbox_link = format!("{}/inbox", context.settings().get_protocol_and_hostname()); | |||
There was a problem hiding this comment.
Was confused at first, but yes this does make sense, its their lemmy-ui inbox page.
| &inserted_local_user.email.expect("email was provided"), | ||
| &inserted_person.name, | ||
| &local_user_view, | ||
| &email, |
There was a problem hiding this comment.
Ah, iirc email is only in LocalUser, not the LocalUserSettings or Safe.
There was a problem hiding this comment.
Not sure what you mean, local_user_view contains LocalUser. And I dont think i changed any of the logic.
crates/utils/translations/en.json
Outdated
| "notification_mentioned_by_body": "<h1>Person Mention</h1><br><div>{username} - {comment_text}</div><br><a href={inbox_link}>inbox</a>", | ||
| "notification_private_message_subject": "Private message from {username}", | ||
| "notification_private_message_body": "<h1>Private message</h1><br><div>{username} - {message_text}</div><br><a href={inbox_link}>inbox</a>" | ||
| } |
There was a problem hiding this comment.
Nice, this is pretty easy, as long as its positional then.
Not super looking forward to setting up a third weblate for lemmy... but its pry gonna need one.
There was a problem hiding this comment.
Yes, at least temporarily until the rosetta crate is updated.
| } | ||
|
|
||
| pub fn get_user_lang(user: &LocalUserView) -> Lang { | ||
| let user_lang = LanguageId::new(user.local_user.lang.clone()); |
There was a problem hiding this comment.
If this doesn't work correctly for things like pt-br, we might have to unfortunately create mappings. But lets not worry about that yet.
Nutomic
force-pushed
the
email-localization
branch
from
61bd53d
to
eb5d255
Compare
Nutomic
force-pushed
the
email-localization
branch
3 times, most recently
from
1b41054
to
0a7474d
Compare
dessalines
force-pushed
the
email-localization
branch
from
0a7474d
to
311edcf
Compare
Nutomic
force-pushed
the
email-localization
branch
from
311edcf
to
a32cd77
Compare
dessalines
force-pushed
the
email-localization
branch
from
a32cd77
to
e554eea
Compare
dessalines
force-pushed
the
email-localization
branch
from
e554eea
to
53f2399
Compare
|
I setup weblate translations. |
Needs some clarifications from upstream: baptiste0928/rosetta#5